Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate KPOps API from the CLI #489

Merged
merged 13 commits into from
May 23, 2024
Merged

Separate KPOps API from the CLI #489

merged 13 commits into from
May 23, 2024

Conversation

raminqaf
Copy link
Contributor

No description provided.

@raminqaf raminqaf mentioned this pull request May 21, 2024
Merged
@raminqaf raminqaf changed the title [WIP]: Separate KPOps API from the CLI Separate KPOps API from the CLI May 21, 2024
@raminqaf raminqaf self-assigned this May 21, 2024
@raminqaf raminqaf added the type/refactor Refactoring of existing functionality label May 21, 2024
@raminqaf raminqaf marked this pull request as ready for review May 21, 2024 14:20
disrupted
disrupted requested changes May 21, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🤩

kpops/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline.py Outdated Show resolved Hide resolved
kpops/pipeline.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted May 22, 2024 08:50
disrupted
disrupted reviewed May 22, 2024
View reviewed changes
kpops/api/registry.py Outdated Show resolved Hide resolved
kpops/api/api.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed May 22, 2024
View reviewed changes
kpops/api/custom_formatter.py Outdated Show resolved Hide resolved
kpops/api/api.py Outdated Show resolved Hide resolved
disrupted
disrupted reviewed May 22, 2024
View reviewed changes
kpops/cli/main.py Outdated Show resolved Hide resolved
@raminqaf raminqaf requested a review from disrupted May 22, 2024 11:52
disrupted
disrupted requested changes May 22, 2024
View reviewed changes
kpops/cli/main.py Outdated Show resolved Hide resolved
disrupted
disrupted requested changes May 22, 2024
View reviewed changes
kpops/api/__init__.py Outdated Show resolved Hide resolved
@raminqaf raminqaf changed the base branch from main to v6 May 22, 2024 13:56
@raminqaf raminqaf requested a review from disrupted May 22, 2024 13:56
disrupted
disrupted approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@disrupted disrupted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great effort! 🙌🏻

@disrupted disrupted added the breaking-change Indicates that this PR introduces a breaking change label May 22, 2024
@raminqaf raminqaf merged commit 980f326 into v6 May 23, 2024
8 of 9 checks passed
@raminqaf raminqaf deleted the refactor/kpops-api branch May 23, 2024 05:18
raminqaf added a commit that referenced this pull request May 27, 2024
@raminqaf
Deploy multiple pipelines (#487)
8773f62 
Depends on #489 
Closes #22
@disrupted disrupted added this to the v6 milestone May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disrupted disrupted disrupted approved these changes

@sujuka99 sujuka99 Awaiting requested review from sujuka99

@irux irux Awaiting requested review from irux

Assignees

@raminqaf raminqaf

Labels
breaking-change Indicates that this PR introduces a breaking change type/refactor Refactoring of existing functionality
Projects
None yet
Milestone
v6
Development

Successfully merging this pull request may close these issues.
2 participants
@raminqaf @disrupted